-
Notifications
You must be signed in to change notification settings - Fork 163
[feature] add backup view for libraries v2 #2532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[feature] add backup view for libraries v2 #2532
Conversation
Thanks for the pull request, @holaontiveros! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
5d2d2b7
to
e6ef987
Compare
e6ef987
to
70aefaa
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2532 +/- ##
========================================
Coverage 94.74% 94.74%
========================================
Files 1206 1212 +6
Lines 27042 27169 +127
Branches 5922 6106 +184
========================================
+ Hits 25620 25742 +122
- Misses 1364 1369 +5
Partials 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/library-authoring/backup-restore/LibraryBackupPage.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, though I have some suggestions for making the tests more consistent with the other new tests in our codebase. Most of this is optional feedback so don't feel you have to change every single thing I pointed out.
src/library-authoring/backup-restore/LibraryBackupPage.test.tsx
Outdated
Show resolved
Hide resolved
const mockLibraryData: { data: any } = { data: {} }; | ||
|
||
jest.mock('@src/library-authoring/data/apiHooks', () => ({ | ||
useContentLibrary: () => (mockLibraryData), | ||
})); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be fine but I'd usually recommend the more realistic mock data helpers that we have:
import { mockContentLibrary } from '../data/api.mocks';
mockContentLibrary.applyMock();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did try this one, but somehow the mocks don't apply properly, so the libraryData it's always undefined... not sure why exactly becasue it works in other places that have the exact same scenario... so I'll leave it as is for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right?, I can show you if you want, maybe it's just me after seing the tests for too long 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine for now :p
Description
This PR adds a new view for the v2 libraries which will allow the user to export a backup of the library for later import.
Useful information to include:
Before new dropdown was added:

New dropdown on v2 libraries for tools:

Backup page:

Supporting information
Covers the first part of #2448
Implements the first part of the views this figma design
Testing instructions
Assuming you have a working authoring dev environment and you have the right version of the edx-platform (latest master which includes: openedx/edx-platform#37419)
Other information
Include anything else that will help reviewers and consumers understand the change.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts
,.tsx
).propTypes
,defaultProps
, andinjectIntl
patterns are not used in any new or modified code.src/testUtils.tsx
(specificallyinitializeMocks
)apiHooks.ts
in this repo for examples.messages.ts
files have adescription
for translators to use.../
. To import from parent folders, use@src
, e.g.import { initializeMocks } from '@src/testUtils';
instead offrom '../../../../testUtils'